Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-cli): Categorize errors #27449

Merged
merged 2 commits into from
Oct 15, 2020
Merged

chore(gatsby-cli): Categorize errors #27449

merged 2 commits into from
Oct 15, 2020

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Oct 14, 2020

Description

Categorize a first set of errors that I'm pretty sure are all ErrorCategory.USER.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 14, 2020
pvdz
pvdz previously approved these changes Oct 14, 2020
View reviewed changes
@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 14, 2020
@LekoArts
Copy link
Contributor

As per #27434 it would be fitting to change category?: keyof typeof Category in this PR so that external users get the correct types.

@julienp julienp force-pushed the julienp/error-category branch from 9d7c63b to 0d6a53f Compare October 14, 2020 15:06
abhiaiyer91
abhiaiyer91 previously approved these changes Oct 14, 2020
View reviewed changes
@julienp julienp force-pushed the julienp/error-category branch from 0d6a53f to 834a1e8 Compare October 14, 2020 15:18
@julienp julienp force-pushed the julienp/error-category branch from 834a1e8 to ca6e337 Compare October 14, 2020 15:47
wardpeet
wardpeet reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @julienp this is great! I'll check out my own comments to see how we can improve or maybe split up those errors

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 15, 2020
@gatsbybot gatsbybot merged commit 85c4adc into gatsbyjs:master Oct 15, 2020
This was referenced Nov 6, 2020
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Apr 15, 2024
Open
@monizb monizb mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiaiyer91 abhiaiyer91 abhiaiyer91 left review comments

@wardpeet wardpeet wardpeet approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: cli Related to the Gatsby CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@julienp @LekoArts @pvdz @wardpeet @abhiaiyer91 @gatsbybot