Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(guide): Update GraphCMS data sourcing guide #27475

Merged
merged 4 commits into from
Oct 19, 2020
Merged

docs(guide): Update GraphCMS data sourcing guide #27475

merged 4 commits into from
Oct 19, 2020

Conversation

ynnoj
Copy link
Contributor

@ynnoj ynnoj commented Oct 15, 2020

Description

Updates the Sourcing from GraphCMS guide to use the new gatsby-source-graphcms plugin.

Documentation

N/A

Related Issues

N/A

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 15, 2020
ronakganatra
ronakganatra previously approved these changes Oct 15, 2020
View reviewed changes
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 15, 2020
vladar
vladar reviewed Oct 19, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 Added a couple of suggestions inline.

docs/docs/sourcing-from-graphcms.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-graphcms.md Show resolved Hide resolved
ynnoj and others added 2 commits October 19, 2020 09:05
@ynnoj @vladar
Update docs/docs/sourcing-from-graphcms.md
5a2da52 
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@ynnoj
docs: Add note about beta status
5b8f43e
@ynnoj
Copy link
Contributor Author

ynnoj commented Oct 19, 2020

@vladar Added a beta note. There'll be a subsequent PR to remove the @next release once it's 'stable'.

vladar
vladar approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 19, 2020
@gatsbybot gatsbybot merged commit 47d8041 into gatsbyjs:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notrab notrab notrab left review comments

@vladar vladar vladar approved these changes

@ronakganatra ronakganatra ronakganatra left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ynnoj @vladar @notrab @ronakganatra @LekoArts @gatsbybot