Support user provided babel configs #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the user to provide a babelrc or a babel section in their package.json. It also allows gatsby to be used without having to specifiy a babelrc if the user doesn't need anything past what babel provides as a default. * It resolves all of the paths to become absolute such that the user can crawl upwards as in gatsbyjs#239. * It allows the custom usage of other babel plugins so that decorators work as in gatsbyjs#129.
This is done to support older browsers. Fixes gatsbyjs#264
This will better support versions of npm that do not provide a flat dependency structure
Updates the readme to describe the new behavior of Babel and Gatsby.
|
Alright, I'm fairly happy with how this turned out. Some highlights:
|
|
This is impressive stuff! Way better than what I kludged together! I really like how you've emulated the normal Babel behavior for users. That's exactly how I envision Gatsby working — magic out-of-box awesomesauce experience but can override/extend it just like you would a normal React/Webpack app. I'll have some more time tomorrow evening to thoroughly review this + merge and cut new release. |
|
|
||
| const name = !startsWith(pluginName, 'babel') ? pluginName : `babel-${type}-${pluginName}` | ||
| const pluginInvariantMessage = ` | ||
| You are trying to use a babel plugin which gatsby cannot find. You |
There was a problem hiding this comment.
Capitalize Gatsby here and below.
|
looking good! |
When refering to the main package: * Gatsby is always capitalized * Babel is always capitalized * webpack is always lowercase When refering to an npm package by name, the name becomes lowercase: * babel-loader * json5 * babel-type-* When refering to a specific file it is lowercase: * package.json * .babelrc
Now that the babel config is resolved externally so that it can be stubbed out and tested, webpack.config.js does not know how to change the loader based on the stage.
KyleAMathews
added a commit
that referenced
this pull request
May 11, 2016
Support user provided babel configs Conflicts: lib/utils/webpack.config.js package.json
|
Merged! Will release 0.11 in the morning. |
This was referenced May 11, 2016
ChristopherBiscardi
pushed a commit
to ChristopherBiscardi/gatsby
that referenced
this pull request
Jun 9, 2019
ChristopherBiscardi
pushed a commit
to ChristopherBiscardi/gatsby
that referenced
this pull request
Jun 27, 2019
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
This was referenced May 21, 2021
This was referenced Jun 6, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to provide a babelrc or a babel section in
their package.json. It also allows gatsby to be used without having to
specifiy a babelrc if the user doesn't need anything past what babel
provides as a default.
crawl upwards as in post-build.js should be moved into gatsby-node.js #239.
work as in Decorators causes Gatsby to crash #129.