fix(gatsby): account for edge case when payload of DELETE_NODE is undefined #27929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out a payload of the
DELETE_NODE
action can beundefined
in some edge cases (no idea when exactly). And refactor from #27504 didn't account for this. This causesCannot read property 'id' of undefined'
error (again, hard to say in which circumstances).This PR fixes this problem by using the same strategy as other reducers (just treats this situation as a no-op). Example from other reducer:
gatsby/packages/gatsby/src/redux/reducers/nodes.ts
Lines 21 to 26 in 557139e