Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typescript definitions for google analytics config #27935

Conversation

forivall
Copy link

Description

Add typescript definitions for the config for the google analytics plugin

Documentation

Documentation already exists at https://www.gatsbyjs.com/plugins/gatsby-plugin-google-analytics

Related Issues

N/A

@forivall forivall requested a review from a team as a code owner November 10, 2020 03:59
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 10, 2020
@LekoArts LekoArts added topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 10, 2020
@LekoArts
Copy link
Contributor

Hey! Thanks so much for opening this pull request!

Sadly this PR got stale and didn't have any activity for some time. We're trying to do better with PR reviews! To get a better overview of all actionable PRs we're going through all open PRs and triage them. Since we won't be able to do everything and adding new features always means added maintenance burden, we have to be more picky about what's beneficial for the average user and the project itself longterm.

Having said all this, we dropped the ball on this PR and we're sorry about not responding to it earlier. As said above, we want to do better in the future but here we should have communicated earlier what will happen with the PR.

Unfortunately we won't merge this PR at the moment because we need a better, more generalized strategy at providing types for plugin options. Manually typing them for each plugin isn't an option and we should generate them from the pluginOptionsSchema API. But that's not done yet.

We absolutely want to have you as a contributor and are sorry for any inconveniences we caused with replying too late to this PR.

Thanks for submitting to Gatsby! 💜

@LekoArts LekoArts closed this Jul 22, 2022
@forivall
Copy link
Author

Sounds like you'll be looking for something like joi-to-typescript to autogenerate the types? Sounds great! Unfortunately, I'm not really working on the project I was using gatsby for anymore, so yeah, replying late means I'm probably not going to hop on that effort any time soon. Good luck with the rest of the typescript migration in #21995! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants