Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gatsby): fix performance regression with query dependency cleaning (#28032) #28100

Closed
wants to merge 1 commit into from

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Nov 16, 2020

Backporting #28032 to the release branch

(cherry picked from commit de5517b)

…ng (#28032)

* perf(gatsby): fix performance regression with query dependency cleaning

* update snapshot

* More consistent codestyle

(cherry picked from commit de5517b)
@vladar vladar requested a review from a team as a code owner November 16, 2020 10:24
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 16, 2020
@vladar vladar added type: cherry and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 16, 2020
@vladar
Copy link
Contributor Author

vladar commented Nov 16, 2020

This can have undesired effects on sites with existing cache as the inversed map will be out of sync. Can be a surprising thing for a patch release. So let's not merge it as a hotfix and instead just publish in the next minor.

@vladar vladar closed this Nov 16, 2020
@LekoArts LekoArts deleted the backport-28032 branch November 16, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant