fix(gatsby-react-router-scroll): Respect hash as source of truth for scroll position

[sidharthachatterjee]

Currently we do not navigate correctly to hashes unless the scroll position is zero. If you're scrolled to any position other than the top, you will need to click twice to scroll to the correct position. This behaviour is completely broken at the moment.

This PR fixes this (albeit not completely) by always respecting the hash and scrolling to it irrespective of if there is browser scrolling state or not. This is iteratively better than our current behaviour. However, the ideal behaviour (which we ought to handle in a separate PR) is to respect hash except when navigating back in the browser (in which case, we ought to restore scroll position). Reach currently has this bug which we can track at reach/router#228

Closes #25778

[mxstbr]

This is so much better than before! 💯 Let's see if we can fix the reach bug in the future, but this is a massive improvement over users having to double click on links to navigate to anchors.

[KyleAMathews]

Ooo nice! I'd noticed this too.

[sidharthachatterjee]

@KyleAMathews Yeah, it was annoying one. @mxstbr and I paired on this earlier today.

[sophstad]

@sidharthachatterjee Thanks for this fix, very much appreciated! Was wondering about this:

the ideal behaviour (which we ought to handle in a separate PR) is to respect hash except when navigating back in the browser (in which case, we ought to restore scroll position)

Is there an issue/PR where we can track this work? Thanks!

[blueboxes]

Has a fix been merged in? I am using gatsby-react-router-scroll 3.7 and still seeing the issue

[TheDarkStrix]

Using gatsby-react-router-scroll gatsby-react-router-scroll": "^3.7.0" still doesn't fix the issue, is there anything that must be done specific to get this working ?

the current implementation :

<Link to={"#contact"} > Contact </Link>

in the other div :
<div id="#contact" >.....</div>

[1-800-jono]

I can also confirm that this is not working using gatsby-react-router-scroll": "^3.7.0"