Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsbu-source-contentful): apply useNameForId when creating the g… #28649

Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix(gatsbu-source-contentful): apply useNameForId when creating the g… #28649

merged 1 commit into from
Jan 14, 2021

Conversation

kaneshin
Copy link
Contributor

Description

Apply useNameForId when the graphql schema on gatsby build phase.

It was degraded by the commit.

Documentation

This is the document but it doesn't need to update.

Related Issues

Fixes #28329

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 16, 2020
@axe312ger
Copy link
Collaborator

Thank you @kaneshin.

Could you please format the code with prettier?

You can run npm run format:code in the Gatsby repository to do it :)

/home/circleci/project/packages/gatsby-source-contentful/src/gatsby-node.js
  349:26  error  Replace `_.camelCase(` with `⏎········_.camelCase(⏎··········`  prettier/prettier
  350:1   error  Insert `····`                                                   prettier/prettier
  351:1   error  Replace `··········` with `··············`                      prettier/prettier
  352:1   error  Insert `····`                                                   prettier/prettier
  353:7   error  Replace `}`)` with `····}`⏎········)⏎······`                    prettier/prettier

@kaneshin
Copy link
Contributor Author

OK. I'll format it later. Thanks for letting to know.

@axe312ger
Copy link
Collaborator

@kaneshin thank you :)

@kaneshin
Copy link
Contributor Author

Hi @axe312ger

I formatted the code then the linter was succeeded on CircleCI.

@LekoArts LekoArts added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 17, 2020
@axe312ger
Copy link
Collaborator

Rerunning CI

@kaneshin
Copy link
Contributor Author

@axe312ger How's it? I have no permission to run the CI. Thank you. ;)

Copy link
Collaborator

@axe312ger axe312ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this works great. Sorry for the inconvenience.

@ascorbic ascorbic merged commit a3ad6d7 into gatsbyjs:master Jan 14, 2021
@kaneshin kaneshin deleted the sharp-28329 branch January 14, 2021 12:33
@kaneshin
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-source-contentful useNameForId is inconsistently applied when creating the graphql schema
4 participants