Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-styled-components): add namespace option #29095

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix(gatsby-plugin-styled-components): add namespace option #29095

merged 1 commit into from
Jan 25, 2021

Conversation

nathanchu
Copy link
Contributor

@nathanchu nathanchu commented Jan 20, 2021

Description

Adds the namespace option to gatsby-plugin-styled-components.
Since this is used as part of a classname, the regex /^-?[_a-zA-Z]+[_a-zA-Z0-9-]*$/ could also be used, but I haven't included it

Documentation

Already included in styled-components docs

Related Issues

Fixes #29057

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 20, 2021
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts added topic: styled-components and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 25, 2021
@LekoArts LekoArts merged commit 1a09302 into gatsbyjs:master Jan 25, 2021
@nathanchu nathanchu deleted the patch-1 branch January 27, 2021 03:15
ascorbic added a commit that referenced this pull request Jan 28, 2021
* Add types for resolver utils

* Fix

* fix(gatsby-plugin-styled-components): add `namespace` option (#29095)

* chore(docs): Netlify CMS added branch to backend settings (#29162)

* docs: fix broken link (#29163)

* chore(docs): Update debugging-the-build-process (#29067)

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Add cassandra to list of database sources (#29137)

Co-authored-by: Lennart <lekoarts@gmail.com>

* feat(contentful): add support for gatsby-plugin-image

* make gatsby-plugin-image a dependency again and warn users about the beta feature

* WIP - support traced svgs again

* Update packages/gatsby-source-contentful/src/extend-node-type.js

Co-authored-by: Matt Kane <matt@gatsbyjs.com>

* fix: set progressive jpg parameter only when format is forced to jpg

* feat: add support for contentful backgorund parameter

* feat: add support for dominant color placeholder

* Error handling, and update api

* Use helper

* Remove gratuitous parseInt on a number

* Destructured import

Co-authored-by: Nathan Chu <63111210+nathanchu@users.noreply.github.com>
Co-authored-by: Himanshu Bisht <32536536+Himanshu-27@users.noreply.github.com>
Co-authored-by: Yuki Takemoto <mottox2@users.noreply.github.com>
Co-authored-by: yonatanLehman <32838532+yonatanLehman@users.noreply.github.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Alex Leventer <alexleventer@gmail.com>
Co-authored-by: Benedikt Rötsch <opensource@axe312.dev>
Co-authored-by: Benedikt Rötsch <axe312ger@users.noreply.github.com>
@LekoArts LekoArts added the topic: plugins-styling Relates to the styling (e.g. CSS-in-JS, SASS, PostCSS) label May 28, 2021
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins-styling Relates to the styling (e.g. CSS-in-JS, SASS, PostCSS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namespace option is not whitelisted in gatsby-plugin-styled-components
2 participants