Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: launch gatsby-source-wordpress v4 #29150

Merged
merged 37 commits into from
Feb 4, 2021

Conversation

TylerBarnes
Copy link
Contributor

This brings all of https://github.com/gatsbyjs/gatsby-source-wordpress-experimental over here:

  • updates all references of gatsby-source-wordpress-experimental to gatsby-source-wordpress
  • The package.json version was manually bumped to 4.0.0
  • Added a new starter gatsby-starter-wordpress-blog

I'm 99% sure the tests aren't working yet and there are likely some config files that can be removed but this is a good start.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 23, 2021
@TylerBarnes TylerBarnes added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 23, 2021
@wardpeet wardpeet self-assigned this Jan 27, 2021
@TylerBarnes TylerBarnes marked this pull request as ready for review February 2, 2021 22:53
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, nothing blocking for merge so if you rather merge first that's fine as well.

How will we create these Wordpress docs moving forward? Will they stay inside gatsby-source-wordpress or rather move to /docs? How do you see it evolving?

packages/gatsby-source-wordpress/babel.config.js Outdated Show resolved Hide resolved
packages/gatsby-source-wordpress/LICENSE Outdated Show resolved Hide resolved
packages/gatsby-source-wordpress/style.css Show resolved Hide resolved
packages/gatsby-source-wordpress/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-wordpress/package.json Show resolved Hide resolved
packages/gatsby-source-wordpress/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-wordpress/package.json Outdated Show resolved Hide resolved
wardpeet
wardpeet previously approved these changes Feb 3, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to merge, let's do some cleanup ~ make sure tests are wired in, in follow up PRs

wardpeet
wardpeet previously approved these changes Feb 3, 2021
@wardpeet wardpeet merged commit 862637b into master Feb 4, 2021
@wardpeet wardpeet deleted the feat/launch-gatsby-source-wordpress-v4 branch February 4, 2021 00:53
vladar pushed a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

(cherry picked from commit 862637b)
vladar added a commit that referenced this pull request Feb 4, 2021
* Feat: launch gatsby-source-wordpress v4 (#29150)

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>

(cherry picked from commit 862637b)

* fix dependency versions

* update yarn.lock

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants