Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contentful): retry on network errors when checking credentials #29664

Merged
merged 1 commit into from
Feb 22, 2021
Merged

fix(contentful): retry on network errors when checking credentials #29664

merged 1 commit into from
Feb 22, 2021

Conversation

axe312ger
Copy link
Collaborator

Network errors can happen any time, our credential check had no retry which broke some builds because of network hick-ups.

This adds a small retry wrapper to the fetch call via https://github.com/vercel/fetch-retry to solve this issue.

Will add tests for (retrying of) network errors later on when adding retry to other parts of the plugin the near future.

@axe312ger axe312ger added status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful labels Feb 22, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
@ascorbic ascorbic merged commit b95a199 into master Feb 22, 2021
@ascorbic ascorbic deleted the fix/contentful-network-errors branch February 22, 2021 16:20
@gatsbybot gatsbybot mentioned this pull request Feb 22, 2021
Merged
ascorbic pushed a commit that referenced this pull request Feb 22, 2021
@axe312ger @ascorbic
fix(contentful): retry on network errors when checking credentials (#…
c1a13f2 
…29664)

(cherry picked from commit b95a199)
ascorbic pushed a commit that referenced this pull request Feb 23, 2021
@axe312ger
fix(contentful): retry on network errors when checking credentials (#…
2625159 
…29664) (#29672)

(cherry picked from commit b95a199)

Co-authored-by: Benedikt Rötsch <axe312ger@users.noreply.github.com>
@ascorbic
Copy link
Contributor

Published in gatsby-source-contentful@4.6.3

This was referenced Feb 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
This was referenced May 5, 2021
Open
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 30, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 30, 2022
Open
@0xSebin 0xSebin mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
This was referenced Oct 31, 2022
Open
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
This was referenced Oct 31, 2022
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Dec 6, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Dec 6, 2023
Open
This was referenced Dec 6, 2023
Open
Open
@monizb monizb mentioned this pull request Dec 6, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 7, 2023
Open
@wizbit wizbit mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 7, 2023
Open
Open
Open
@impactyogi impactyogi mentioned this pull request Dec 7, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 7, 2023
Open
Open
@impactyogi impactyogi mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axe312ger @ascorbic @wardpeet