Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Contentful e2e test snapshots #31073

Merged
merged 5 commits into from
May 20, 2021
Merged

update Contentful e2e test snapshots #31073

merged 5 commits into from
May 20, 2021

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Apr 27, 2021 •
edited
Loading

Recently we updated to a new major version of remark. This PR aligns the snapshots.

Some smaller things are strange, will highlight these with comments.

@axe312ger axe312ger added status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful labels Apr 27, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 27, 2021
@axe312ger axe312ger requested a review from wardpeet April 27, 2021 14:04
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 28, 2021
@axe312ger
Copy link
Collaborator Author

@wardpeet what shall we do about these rendering changes?

Especially the empty comments (<!-- -->) worry me

@axe312ger axe312ger force-pushed the test/update-contentful-snapshots branch from fffba94 to cb91e9c Compare May 12, 2021 08:20
@axe312ger axe312ger force-pushed the test/update-contentful-snapshots branch from b752615 to be1b549 Compare May 20, 2021 08:59
@axe312ger axe312ger added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels May 20, 2021
vladar
vladar approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks 🚢

@gatsbybot gatsbybot merged commit 7316958 into master May 20, 2021
@gatsbybot gatsbybot deleted the test/update-contentful-snapshots branch May 20, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axe312ger @vladar @LekoArts @gatsbybot