-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTF-v6: Rename schema types #31286
Merged
axe312ger
merged 6 commits into
feat/contentful-schema-generation
from
refactor/contentful-rename-schema-types
Jun 11, 2021
Merged
CTF-v6: Rename schema types #31286
axe312ger
merged 6 commits into
feat/contentful-schema-generation
from
refactor/contentful-rename-schema-types
Jun 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 6, 2021
axe312ger
changed the base branch from
master
to
feat/contentful-schema-generation
May 6, 2021 14:25
axe312ger
added
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: source-contentful
Related to Gatsby's integration with Contentful
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
May 6, 2021
17 tasks
axe312ger
changed the title
Refactor(contentful): rename schema types
CTF-v6: Rename schema types
May 12, 2021
25 tasks
axe312ger
force-pushed
the
refactor/contentful-rename-schema-types
branch
2 times, most recently
from
May 12, 2021 15:04
e8bf32f
to
d560a17
Compare
axe312ger
force-pushed
the
refactor/contentful-rename-schema-types
branch
from
May 20, 2021 09:09
d560a17
to
8d6fb8d
Compare
axe312ger
force-pushed
the
feat/contentful-schema-generation
branch
from
May 20, 2021 09:11
810ba34
to
95366fc
Compare
axe312ger
force-pushed
the
refactor/contentful-rename-schema-types
branch
from
May 20, 2021 09:16
8d6fb8d
to
3842e1f
Compare
axe312ger
force-pushed
the
feat/contentful-schema-generation
branch
from
May 20, 2021 14:10
95366fc
to
4656166
Compare
axe312ger
force-pushed
the
refactor/contentful-rename-schema-types
branch
from
May 21, 2021 10:00
3842e1f
to
115ee2a
Compare
axe312ger
force-pushed
the
feat/contentful-schema-generation
branch
2 times, most recently
from
June 10, 2021 16:06
61f846c
to
a5ddad2
Compare
axe312ger
force-pushed
the
refactor/contentful-rename-schema-types
branch
2 times, most recently
from
June 11, 2021 09:04
c7ff45c
to
d0ae16e
Compare
axe312ger
force-pushed
the
refactor/contentful-rename-schema-types
branch
from
June 11, 2021 10:16
d0ae16e
to
f7d6a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: source-contentful
Related to Gatsby's integration with Contentful
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #30855 and renames all types closer to what the Contentful GraphQL API does
Breaking changes / steps to migrate
New content type naming pattern
The old naming pattern for generated node types based on your Contentful content model was pretty simple. This gave us shorter queries, but came with restrictions for content type names. Content type names like
entity
,reference
,tag
,asset
did cause problems or simply did not work.ContentfulContentType
instead ofContentful
ContentfulEntry
,ContentfulAsset
,ContentfulLocation
orContentfulRichText
This is close to the behaviour of the Contentful GraphQL API:
Instead of doing this on a collision, we always prefix for consistency.