Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough draft of instructions for adding tags/categories #3161

Merged
merged 8 commits into from
Dec 14, 2017

Conversation

melissamcewen
Copy link
Contributor

Hey it's my first time writing some documentation for Gatsby, I'd love your feedback.

@melissamcewen
Copy link
Contributor Author

Also I learned a lot of this from https://github.com/DSchau/gatsby-blog-starter-kit though I modified it over time, so not sure where I should credit that

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 8, 2017

Deploy preview ready!

Built with commit fb2360f

https://deploy-preview-3161--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 8, 2017

Deploy preview ready!

Built with commit 5904579

https://deploy-preview-3161--gatsbygram.netlify.com

adding instructions on creating a tag component and linking to tags from blog post page
@Jaikant
Copy link
Contributor

Jaikant commented Dec 12, 2017

A few additions.

  1. In section “Creating Tag Pages”
  • 

In the first code snippet at the end there is a typo it uses "Link" instead of "GatsbyLink"
  • 
In the second code snippet, the import is not necessary const { createFilePath } = require(gatsby-source-filesystem)
  • File gatsby-node.js, the createTagPages function will have to be called from within createPages
  1. After adding fields to markdown, if we are in development mode by running ‘gatsby develop’, I had to do a restart for the new data to be available to GraphQL. [Not sure if this is always the case, but putting it out there, if it helps anyone]

@melissamcewen
Copy link
Contributor Author

Thanks! I'll make those revisions!

@KyleAMathews
Copy link
Contributor

Awesome! Thanks for tackling this @melissamcewen!

@melissamcewen
Copy link
Contributor Author

Great, just made those corrections!

@ghost ghost assigned KyleAMathews Dec 14, 2017
@ghost ghost added the review label Dec 14, 2017
@KyleAMathews
Copy link
Contributor

Thanks!

@KyleAMathews KyleAMathews merged commit a6b8a9c into gatsbyjs:master Dec 14, 2017
@ghost ghost removed the review label Dec 14, 2017
@jlengstorf
Copy link
Contributor

Hiya @melissamcewen! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants