refactor(contentful): migrate to schema customization API #32351
Conversation
…g dominat color or tracing svg
axe312ger
added
the
topic: source-contentful
gatsbot
bot
added
the
status: triage needed
| @@ -1,30 +1,19 @@ | |||
| const path = require(`path`) | |||
| const isOnline = require(`is-online`) | |||
| // @todo import syntax! | |||
There was a problem hiding this comment.
reminder to myself: time to finally get all files to es-module syntax
| @@ -1,30 +1,19 @@ | |||
| const path = require(`path`) | |||
| const isOnline = require(`is-online`) | |||
| // @todo import syntax! | |||
There was a problem hiding this comment.
reminder to myself: time to finally get all files to es-module syntax
|
|
||
| // If the cache has data, use it. Otherwise do a remote fetch anyways and prime the cache now. | ||
| // If present, do NOT contact contentful, skip the round trips entirely | ||
| if (forceCache) { |
There was a problem hiding this comment.
This experimental flag adds some complexity to this code we could avoid.
I can't find any documentation to it as well
| } | ||
| }) | ||
|
|
||
| // @todo based on the sys metadata we should be able to differentiate new and updated entities |
There was a problem hiding this comment.
should be low effort, also pretty low impact on the whole build time
| } | ||
| }) | ||
|
|
||
| // @todo based on the sys metadata we should be able to differentiate new and updated entities |
There was a problem hiding this comment.
should be low effort, also pretty low impact on the whole build time
| // Remove deleted entries & assets | ||
| reporter.verbose(`Removing deleted Contentful entries & assets`) | ||
|
|
||
| // @todo this should happen when sourcing? |
There was a problem hiding this comment.
IMHO any interaction with actual nodes should happen in source-nodes. WDYT?
| } | ||
| }) | ||
|
|
||
| const creationActivity = reporter.activityTimer( |
There was a problem hiding this comment.
@todo consider including all the map creation and loops in the creation activity.
|
|
||
| // A contentType can hold lots of entries which create nodes | ||
| // We wait until all nodes are created and processed until we handle the next one | ||
| // TODO add batching in gatsby-core |
There was a problem hiding this comment.
@wardpeet do we have any kind of new API that could help here? That comment is for sure very old
|
|
||
| creationActivity.end() | ||
|
|
||
| // @todo add own activity! |
axe312ger
added
the
type: maintenance
LekoArts
removed
the
status: triage needed
wardpeet
force-pushed
the
refactor/contentful-asset-dowloading
branch
from
e01c0f0 to
e955764
Compare
wardpeet
force-pushed
the
refactor/contentful-asset-dowloading
branch
2 times, most recently
from
2ae4698 to
3f686a0
Compare
axe312ger
force-pushed
the
refactor/contentful-asset-dowloading
branch
from
f441cb3 to
8bda979
Compare
axe312ger
deleted the
refactor/contentful-use-schema-customization-api
branch
The plugin filled up
sourceNodeswith a bunch of things. This PR cleans this up, moves large chunks of the code in separate files and their correct GatsbyJS API hooks.Current status:
gatsby-node.jsstill need to be refactored. This might be a great time to restructure these huge fixture json files?