chore(gatsby): remove unused packages #32903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
commented
Aug 25, 2021
| @@ -166,7 +159,6 @@ | |||
| "devDependencies": { | |||
| "@babel/cli": "^7.14.8", | |||
| "@babel/register": "^7.14.0", | |||
| "@babel/runtime": "^7.14.8", | |||
There was a problem hiding this comment.
This is also in dependencies
|
@wardpeet what's this library/tool you used to generate the graph? |
|
@herecydev I always use https://npm.anvaka.com/#/ |
wardpeet
commented
Aug 25, 2021
| @@ -27,7 +27,7 @@ describe(`SSR`, () => { | |||
| test(`dev & build outputs match`, async () => { | |||
| const childProcess = await execa(`yarn`, [`test-output`]) | |||
|
|
|||
| expect(childProcess.code).toEqual(0) | |||
| expect(childProcess.exitCode).toEqual(0) | |||
There was a problem hiding this comment.
I'm not sure why this change was necessary but code returns undefined
wardpeet
added
type: maintenance
vladar
approved these changes
Aug 26, 2021
wardpeet
added a commit
that referenced
this pull request
Aug 27, 2021
This was referenced Aug 31, 2021
This was referenced Oct 19, 2024
This was referenced Oct 20, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed some unsued packages that we imported. This PR removes them, the biggest offender is webpack-dev-server