feat(gatsby-core-utils): add fetch mutex for PQR #33161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
gatsby 4
topic: data
vladar
reviewed
Sep 14, 2021
Comment on lines
96
to
106
| if (entry.status === `complete`) { | ||
| cb(entry.result) | ||
| } else { | ||
| setTimeout(() => { | ||
| pollUntilComplete(cache, url, buildId, cb) | ||
| // Magic number | ||
| }, 500) | ||
| } |
There was a problem hiding this comment.
What happens if a worker starts polling but then the "main" worker fails (i.e. requestRemoteNode throws)? I don't see how it can exist from this function in this case. Can we have a test case for it as it is a typical scenario?
There was a problem hiding this comment.
We keep on hanging 😂 good point but wouldn't the process fail anyway?
There was a problem hiding this comment.
Depends on how folks use it. If it happens in custom resolver - the corresponding field can just return null (graphql allows partial errors for nullable fields)
wardpeet
force-pushed
the
feat/add-fetch-mutex
branch
from
1c4c889 to
a574044
Compare
vladar
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When multiple workers fetch the same file we end up with multiple requests to that file. We write to a seperate tmp file but the end result writes (fs.move) to the same file.
This can lead to corrupt files if other parts of the application are resolving it. This PR creates some hacky mutex implementation to make it only write once. It's still possible to write multiple tmp files.
As an adittion I took the inFlight cache from #30391 and implemented it as well to do less polling.