Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

Merged
merged 4 commits into from
Sep 14, 2021
Merged

fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed925aa
fix(gatsby-source-drupal): check relationships type exists on node be…
KyleAMathews Sep 14, 2021
6d93849
Merge remote-tracking branch 'origin/master' into nuder-drupal-fix
KyleAMathews Sep 14, 2021
6e5d0dd
Update packages/gatsby-source-drupal/src/utils.js
KyleAMathews Sep 14, 2021
53ee03e
format
KyleAMathews Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/gatsby-source-drupal/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const {
nodeFromData,
downloadFile,
isFileNode,
getHref,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't being used

createNodeIdWithVersion,
} = require(`./normalize`)

Expand Down Expand Up @@ -262,10 +261,15 @@ ${JSON.stringify(nodeToUpdate, null, 4)}

const nodeFieldName = `${newNode.internal.type}___NODE`
removedReferencedNodes.forEach(referencedNode => {
referencedNode.relationships[nodeFieldName] =
referencedNode.relationships[nodeFieldName].filter(
id => id !== newNode.id
)
if (
referencedNode.relationships &&
referencedNode.relationships[nodeFieldName]
) {
referencedNode.relationships[nodeFieldName] =
referencedNode.relationships[nodeFieldName].filter(
id => id !== newNode.id
)
}
})

// see what nodes are newly referenced, and make sure to call `createNode` on them
Expand Down