fix(gatsby-source-drupal): Add tests for meta.count support & fix bug with i18n #33423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main guerentee that this is working is that only the first articles json file has a next href so the only way all articles are fetched is if we create the URLs upfront.
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: source-drupal
benrobertsonio
approved these changes
Oct 5, 2021
KyleAMathews
added a commit
that referenced
this pull request
Oct 5, 2021
… with i18n (#33423) * feat(gatsby-source-drupal): port hot-fixes for Drupal/Gatsby customer to package * Add tests for meta.count URL creation The main guerentee that this is working is that only the first articles json file has a next href so the only way all articles are fetched is if we create the URLs upfront. * Add tests for meta.count for i18n (and fix bug for it) * Make paths windows-happy Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
vladar
pushed a commit
that referenced
this pull request
Oct 5, 2021
… with i18n (#33423) * feat(gatsby-source-drupal): port hot-fixes for Drupal/Gatsby customer to package * Add tests for meta.count URL creation The main guerentee that this is working is that only the first articles json file has a next href so the only way all articles are fetched is if we create the URLs upfront. * Add tests for meta.count for i18n (and fix bug for it) * Make paths windows-happy Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 22805bd)
vladar
pushed a commit
that referenced
this pull request
Oct 5, 2021
… with i18n (#33423) (#33440) * feat(gatsby-source-drupal): port hot-fixes for Drupal/Gatsby customer to package * Add tests for meta.count URL creation The main guerentee that this is working is that only the first articles json file has a next href so the only way all articles are fetched is if we create the URLs upfront. * Add tests for meta.count for i18n (and fix bug for it) * Make paths windows-happy Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 22805bd) Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
|
@KyleAMathews legend 🍻 |
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
… with i18n (gatsbyjs#33423) * feat(gatsby-source-drupal): port hot-fixes for Drupal/Gatsby customer to package * Add tests for meta.count URL creation The main guerentee that this is working is that only the first articles json file has a next href so the only way all articles are fetched is if we create the URLs upfront. * Add tests for meta.count for i18n (and fix bug for it) * Make paths windows-happy Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing for #32883
Fixes #33186 as well.