-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-source-contentful): download assets via gatsby-core-utils #33482
Conversation
8a47a37
to
9a542a9
Compare
9a542a9
to
59d93d6
Compare
59d93d6
to
c7a2cfc
Compare
The old code caches the base64 result files onto the file system. As we now use fetchRemoteFile, I am pretty sure we should be able to remove the following code and remove unnecessary I/O?
Also, am I correct that there are two additional memory caches?
I am sure these have been added by @pvdz for a good reason. Can we run/check the related benchmarks again? |
gatsbyjs#33482) Co-authored-by: Ward Peeters <ward@coding-tech.com>
#33482) Co-authored-by: Ward Peeters <ward@coding-tech.com>
This replaces all custom asset download code with gatsby-core-utils from Gatsby v4.
Primarily as companion for #33461.
We might only merge this for now and see how it behaves, but I am pretty sure we at least need reload on 429s and 503s in core which AFAICS is not in Gatsby core yet.