Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): single page node manifest accuracy #33642

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

TylerBarnes
Copy link
Contributor

This PR makes 2 improvements to the createNodeManifest action:

  • The tests are updated to make sure each test expects the correct foundPageBy property (the way the page was found for the manifest)
  • When there's only 1 related page to a node we were incorrectly storing foundPageBy as queryTracking even if was actually found via ownerNodeId or the filesystem route API

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 22, 2021
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 22, 2021
@TylerBarnes
Copy link
Contributor Author

@KyleAMathews this is why your demo was showing the warnings when you were trying to use ownerNodeId and the filesystem route API. I think your test site only had a single related page for each node manifest 😅

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Oct 22, 2021 via email

@TylerBarnes TylerBarnes merged commit 4b6d04b into master Oct 25, 2021
@TylerBarnes TylerBarnes deleted the fix/single-page-node-manifest branch October 25, 2021 16:02
vladar pushed a commit that referenced this pull request Oct 27, 2021
* expect the manifest has the correct foundPageBy
* ensure foundPageBy is accurate when there's only 1 relevant page

(cherry picked from commit 4b6d04b)
vladar added a commit that referenced this pull request Oct 27, 2021
* expect the manifest has the correct foundPageBy
* ensure foundPageBy is accurate when there's only 1 relevant page

(cherry picked from commit 4b6d04b)

Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
* expect the manifest has the correct foundPageBy
* ensure foundPageBy is accurate when there's only 1 relevant page
axe312ger pushed a commit that referenced this pull request Nov 9, 2021
* expect the manifest has the correct foundPageBy
* ensure foundPageBy is accurate when there's only 1 relevant page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants