doc/tutorial/part-one fixes #3383

joesepi · 2018-01-02T03:43:38Z

I'm familiar with React but new to Gatsby so I was quickly going through the tutorials. I found something confusing (the seemingly unnecessary parentheses as noted in review comments) and figured I would contribute. As a developer advocate, I write a lot of tutorials as well and couldn't resist making some other edits. I hope this small PR is helpful.

joesepi · 2018-01-02T03:44:26Z

docs/tutorial/part-one/index.md

@@ -14,7 +14,7 @@ Sit down, buckle up, and let's get going!

 ## Check your development environment

-Let's check first that you have everything setup to start creating with Gatsby.
+Let's check first that you have everything set up to start creating with Gatsby.


setup is a noun. set up is the phrasal verb being used here.

Amazing — never knew the difference 💯

joesepi · 2018-01-02T03:44:46Z

docs/tutorial/part-one/index.md

@@ -30,7 +30,7 @@ You should see something like:

 ![Check if node.js/npm is installed](check-versions.png)

-Gatsby supports versions of Node back to v4 and NPM to v3.
+Gatsby supports versions of Node back to v4 and npm to v3.


I believe the caps are deprecated. :)

No idea but I'll trust you on this 👍

gatsbybot · 2018-01-02T03:47:30Z

Deploy preview ready!

Built with commit 4822aa3

https://deploy-preview-3383--gatsbygram.netlify.com

joesepi

Explanations of my minor changes.

joesepi · 2018-01-02T03:45:50Z

docs/tutorial/part-one/index.md

@@ -81,18 +81,18 @@ Too cool 😎

 Gatsby's development server is a "hot reloading" server, meaning any change you
 make to your React.js page components (and later we'll learn, your data files)
-will hot reload in the browser.
+will be immediately visible and/or loaded in the browser.


It's better to not use the term your explaining in your explanation.

Haha yes :-)

joesepi · 2018-01-02T03:48:20Z

docs/tutorial/part-one/index.md

@@ -187,12 +187,11 @@ Make the second page component look something like:
 import React from "react";
 import Link from "gatsby-link";

-export default () => (
+export default () =>


This is the reason I started updating this doc. These parentheses seem unnecessary and they are not in the first example. I thought it might confuse someone totally new to React and Gatsby.

We started running Prettier on the markdown code examples recently which perhaps added this? I'll pull your branch locally and run Prettier again and see what happens.

Hmm it did add it back... investigating.

Yeah, it's because the other code blocks earlier have line highlighting e.g. jsx{1-2} which makes Prettier skip over them. We'll be moving soon-ish to an inlined way to mark lines to be highlighted which will make Prettier work more consistently.

Okay. Thanks for looking into this. I noticed it and really wondered what was up.

KyleAMathews

Nice! Really appreciate edits!

KyleAMathews · 2018-01-02T20:00:52Z

docs/tutorial/part-one/index.md

@@ -14,7 +14,7 @@ Sit down, buckle up, and let's get going!

 ## Check your development environment

-Let's check first that you have everything setup to start creating with Gatsby.
+Let's check first that you have everything set up to start creating with Gatsby.


Amazing — never knew the difference 💯

KyleAMathews · 2018-01-02T20:01:18Z

docs/tutorial/part-one/index.md

@@ -30,7 +30,7 @@ You should see something like:

 ![Check if node.js/npm is installed](check-versions.png)

-Gatsby supports versions of Node back to v4 and NPM to v3.
+Gatsby supports versions of Node back to v4 and npm to v3.


No idea but I'll trust you on this 👍

KyleAMathews · 2018-01-02T20:01:32Z

docs/tutorial/part-one/index.md

@@ -81,18 +81,18 @@ Too cool 😎

 Gatsby's development server is a "hot reloading" server, meaning any change you
 make to your React.js page components (and later we'll learn, your data files)
-will hot reload in the browser.
+will be immediately visible and/or loaded in the browser.


Haha yes :-)

KyleAMathews · 2018-01-02T20:03:22Z

docs/tutorial/part-one/index.md

@@ -187,12 +187,11 @@ Make the second page component look something like:
 import React from "react";
 import Link from "gatsby-link";

-export default () => (
+export default () =>


We started running Prettier on the markdown code examples recently which perhaps added this? I'll pull your branch locally and run Prettier again and see what happens.

KyleAMathews · 2018-01-02T20:23:16Z

Thanks!

joesepi · 2018-01-03T04:43:41Z

Thanks for your great responses @KyleAMathews. I plan to go through the other tutorials as well and I'll have them open in Vim as I do so and PR any other updates that may help. Cheers and thanks for all the great work you've put into Gatsby!

KyleAMathews · 2018-01-03T10:13:49Z

Great! Looking forward to your next PRs!

jlengstorf · 2019-02-16T19:44:58Z

Hiya @joesepi! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

doc/tutorial/part-one fixes

f0dcc03

joesepi commented Jan 2, 2018

View reviewed changes

KyleAMathews reviewed Jan 2, 2018

View reviewed changes

No parens around code

4822aa3

ghost assigned KyleAMathews Jan 2, 2018

ghost added the review label Jan 2, 2018

KyleAMathews merged commit cce650e into gatsbyjs:master Jan 2, 2018

ghost removed the review label Jan 2, 2018

X-oss-byte mentioned this pull request Sep 23, 2023

[Snyk] Upgrade bulma from 0.9.0 to 0.9.4 X-oss-byte/gatsby-1#51

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc/tutorial/part-one fixes #3383

doc/tutorial/part-one fixes #3383

joesepi commented Jan 2, 2018 •

edited

Loading

joesepi Jan 2, 2018

KyleAMathews Jan 2, 2018

joesepi Jan 2, 2018

KyleAMathews Jan 2, 2018

gatsbybot commented Jan 2, 2018 •

edited

Loading

joesepi left a comment

joesepi Jan 2, 2018

KyleAMathews Jan 2, 2018

joesepi Jan 2, 2018

KyleAMathews Jan 2, 2018

KyleAMathews Jan 2, 2018

KyleAMathews Jan 2, 2018

joesepi Jan 3, 2018

KyleAMathews left a comment

KyleAMathews Jan 2, 2018

KyleAMathews Jan 2, 2018

KyleAMathews Jan 2, 2018

KyleAMathews Jan 2, 2018

KyleAMathews commented Jan 2, 2018

joesepi commented Jan 3, 2018

KyleAMathews commented Jan 3, 2018

jlengstorf commented Feb 16, 2019

doc/tutorial/part-one fixes #3383

doc/tutorial/part-one fixes #3383

Conversation

joesepi commented Jan 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gatsbybot commented Jan 2, 2018 • edited Loading

joesepi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KyleAMathews left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KyleAMathews commented Jan 2, 2018

joesepi commented Jan 3, 2018

KyleAMathews commented Jan 3, 2018

jlengstorf commented Feb 16, 2019

joesepi commented Jan 2, 2018 •

edited

Loading

gatsbybot commented Jan 2, 2018 •

edited

Loading