Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-contentful): remove duplicate resolving #34599

Merged
merged 3 commits into from
Jan 28, 2022
Merged

fix(gatsby-source-contentful): remove duplicate resolving #34599

merged 3 commits into from
Jan 28, 2022

Conversation

axe312ger
Copy link
Collaborator

We introduced the Contentful JS SDK about 2 years ago to fix issues with resolving nodes.

Our test coverage grew since then, so we now can remove this extra logic.

  • removes caching of the old syncs
  • removes iterations through the whole data set
  • improves reporter output
  • should have some small positive performance impacts, especially on huge projects
  • could remove rich text hack/workaround
  • simplifies maintaining of the plugin

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 26, 2022
@wardpeet wardpeet added status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 28, 2022
wardpeet
wardpeet approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wardpeet wardpeet changed the title Contentful: remove duplicate resolving fix(gatsby-source-contentful): remove duplicate resolving Jan 28, 2022
@wardpeet wardpeet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels Jan 28, 2022
@gatsbybot gatsbybot merged commit 6e955a4 into refactor/contentful-clean-up-tests Jan 28, 2022
@gatsbybot gatsbybot deleted the refactor/contentful-simplify-resolving branch January 28, 2022 12:37
@axe312ger axe312ger mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axe312ger @wardpeet @gatsbybot