Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-graphql): upgrade apollo & graphql-tools deps #34772

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

seanparmelee
Copy link
Contributor

Description

This is a continuation of #34077, where the goal was to bump @graphql-tools/links to pull in some newer transitive dependencies to ultimately fix a deprecation warning that shows up when using gatsby-source-graphql (for more context see #34042). As noted in the previous PR, @apollo/client is a peer dependency of @graphql-tools/links so that dependency was also brought in, which also replaces a number of deprecated apollo packages.

Documentation

I updated all the docs & examples that referenced the older apollo packages.

Related Issues

Fixes #34042

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 9, 2022
.eslintignore Outdated Show resolved Hide resolved
"apollo-link-http": "^1.5.17",
"@graphql-tools/links": "^8.2.1",
"@graphql-tools/utils": "^8.6.1",
"@graphql-tools/wrap": "^8.3.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these @graphql-tools depend on each other, figured it made sense to bump all of them here

@LekoArts LekoArts added topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 9, 2022
@pieh pieh self-assigned this Feb 9, 2022
@teleaziz
Copy link
Contributor

any sense of eta on merging and releasing this?

@presto2116
Copy link

Is there any movement on this? it's been sitting for over a month now. The build log errors/warnings caused by gatsby-source-graphql are pretty irritating, especially since its a deep dependency error that has been fixed with this PR

@jamin84
Copy link

jamin84 commented Mar 14, 2022

Is there any movement on this? it's been sitting for over a month now. The build log errors/warnings caused by gatsby-source-graphql are pretty irritating, especially since its a deep dependency error that has been fixed with this PR

Also looking forward to getting this merged!

@LekoArts LekoArts assigned LekoArts and unassigned pieh Mar 14, 2022
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find anything breaking in dependencies so let's merge and get some feedback on our next channel.

Thank you for upgrading!

@wardpeet wardpeet merged commit d9fe5df into gatsbyjs:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated dependencies on gatsby-source-graphql
8 participants