Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-preact): fix preact alias #35156

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Conversation

wardpeet
Copy link
Contributor

Description

Fixes aliases in Preact
https://preactjs.com/guide/v10/getting-started/#aliasing-react-to-preact

Documentation

Related Issues

Fixes #35145

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 17, 2022
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 17, 2022
@LekoArts
Copy link
Contributor

The pnp tests is always failing at the moment so it's hard to see if this change would break pnp :/

@wardpeet
Copy link
Contributor Author

It won't because webpack will go through pnp

Copy link
Contributor

@marvinjude marvinjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@wardpeet wardpeet merged commit b13ddff into master Mar 18, 2022
@wardpeet wardpeet deleted the fix/preact-alias branch March 18, 2022 09:24
gatsbybot pushed a commit that referenced this pull request Mar 18, 2022
pieh pushed a commit that referenced this pull request Mar 18, 2022
Co-authored-by: Ward Peeters <ward@coding-tech.com>
@pieh
Copy link
Contributor

pieh commented Mar 18, 2022

Published in gatsby-plugin-preact@6.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-preact: Can't resolve 'react/jsx-runtime' with @mui/material
4 participants