fix(gatsby): PnP fixes #35194
Merged
fix(gatsby): PnP fixes #35194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
2 tasks
pieh
commented
Mar 22, 2022
Comment on lines
-353
to
-355
| - run: # TODO: remove pinned version | ||
| command: yarn set version 3.1.1 | ||
| working_directory: /tmp/e2e-tests/gatsby-pnp |
There was a problem hiding this comment.
unpin yarn version in tests, so we start using latest again
pieh
commented
Mar 22, 2022
| defaultConfig: require.resolve(`gatsby-parcel-config`, { | ||
| paths: [siteRoot], | ||
| }), | ||
| defaultConfig: require.resolve(`gatsby-parcel-config`), |
There was a problem hiding this comment.
gatsby-parcel-config is dependency of gatsby not site, so we shouldn't try to resolve it from site context
pieh
commented
Mar 22, 2022
pieh
commented
Mar 22, 2022
Comment on lines
+106
to
+107
|
|
||
| ensuredSendToMain([WORKER_READY]) |
There was a problem hiding this comment.
We didn't have init messaging and seems like in some cases initial messages (before child set on('message') handler) are lost. The change here is that child sends "ready" message once it's initialized and workerpool waits for it before sending task to process
wardpeet
approved these changes
Mar 22, 2022
pieh
added a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 79c5598)
pieh
added a commit
that referenced
this pull request
Mar 22, 2022
|
Published in |
This was referenced Mar 29, 2022
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 14, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Couple of fixes here that seems to impact yarn@2+:
gatsby-parcel-configfromgatsbycontext and not site contextgatsby-workershould await for worker process to be ready before trying to send task to it (we saw in CI at least tests being stuck on "validating engines", which is just first thing we use any worker process for, also yarn run gatsby build stalles in run queries in workers #35192 looks like has similar problem just in different spot, due to repro site not using engines, so we don't try to validate them and first worker usage is actually query running)Related Issues
Fixes #35140
Fixes #35192