fix(gatsby-plugin-image): fix image flickers #35226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: media
wardpeet
force-pushed
the
feat/image-plugin
branch
4 times, most recently
from
78a01e5 to
8ad1e67
Compare
This was referenced Apr 6, 2022
wardpeet
force-pushed
the
feat/image-plugin
branch
from
9c147f7 to
21b6595
Compare
|
@wardpeet I'm having a hard time separating out the parts that are fix-related from the parts that are refactored, can you add some comments (the GitHub kind, not inline 😄) that point that out? Looks great at first glance |
|
That's the tricky bit. With the current component, we were constantly unmounting and remounting. It led to the flicker when you were doing page navigations. The old technique is a way to do partial hydration, so we could stop hydrating gatsby-plugin-image, rely on a snippet in HTML, and only hydrate on state changes or navigations. |
LekoArts
reviewed
Apr 8, 2022
This was referenced Nov 29, 2022
This was referenced Nov 29, 2022
2 tasks
This was referenced Feb 28, 2023
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes gatsby-plugin-image flickering between page navigations and/or state updates.
Related Issues
Fixes #34190
Fixes #34009