chore(gatsby): upgrade @pmmmwh/react-refresh-webpack-plugin #36360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
type: maintenance
|
We also use this for Preact (see #33374) |
pieh
force-pushed
the
chore/upgrade/fast-refresh
branch
from
f4d66cb to
bac1520
Compare
pieh
commented
Aug 14, 2022
Comment on lines
+1
to
+2
| // needed for fast refresh | ||
| import "@gatsbyjs/webpack-hot-middleware/client" |
There was a problem hiding this comment.
Previously refresh plugin would automatically fallback to importing client and using it. After https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/337/files#diff-5425e895a25e9446e7307d31bc2cf26e1a77778571d76656d3b10876e9e48871 hot middleware client needs to be initialized elsewhere in the app and react-refresh will hook up to it (if available)
We can do it here as first import, or follow example and have it in our webpack entry ( https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/5b0ef9b2ee2fb2f4323df3ec628c26b9c72bf0c7/examples/webpack-hot-middleware/webpack.config.js#L10-L12 )
LekoArts
approved these changes
Aug 15, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimistic bump - but might need more changes to work ( https://github.com/pmmmwh/react-refresh-webpack-plugin/releases/tag/v0.5.0 mentions some breaking changes)
Related Issues
[ch54232]