-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): stale node manifests #36988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 8, 2022
canary published as |
LekoArts
added
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Nov 9, 2022
pieh
approved these changes
Nov 9, 2022
DanielSLew
approved these changes
Nov 9, 2022
This was referenced Jan 12, 2023
Open
This was referenced Jan 12, 2023
This was referenced Apr 25, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it seems there are no pending page data writes but there are still node manifests that should be written out.
I added a stale node manifest check to fix it. Always writing them out is problematic since flush can be called multiple times after node manifests are stored and sometimes there aren't pending writes until the second time it's called. When there are pending writes we want to process the node manifests at the same time as page-data.json files because the node manifest ID is added to page-data.json when they're processed at the same time.