Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Restore asset, path prefix for file-loader handled files #37429

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 10, 2023

Description

In #37284 we stopped duplicate output of files, but also removed the ability to set assetPrefix and pathPrefix for files handled by file-loader. This change restores that functionality.

Documentation

N/A

Related Issues

Fixes #37427

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 10, 2023
@tyhopp tyhopp added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 10, 2023
@tyhopp tyhopp changed the title fix(gatsby): Preserve asset, path prefix fix(gatsby): Restore asset, path prefix Jan 10, 2023
@tyhopp tyhopp changed the title fix(gatsby): Restore asset, path prefix fix(gatsby): Restore asset, path prefix for file-loader handled files Jan 10, 2023
@tyhopp tyhopp marked this pull request as ready for review January 10, 2023 04:28
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tests, nice!

@LekoArts LekoArts merged commit b0c0913 into master Jan 10, 2023
@LekoArts LekoArts deleted the fix/path-and-asset-prefix branch January 10, 2023 07:08
LekoArts pushed a commit that referenced this pull request Jan 10, 2023
LekoArts pushed a commit that referenced this pull request Jan 10, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…#37429) (#37430)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
pieh pushed a commit that referenced this pull request Dec 19, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…#38764)

* fix(gatsby): Restore asset, path prefix for file-loader handled files (#37429)

* add missing import, read vars from config

---------

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image URLs from file loader no longer have asset prefix in 5.3.3
2 participants