Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): New "Creating a Source Plugin" tutorial #37538
chore(docs): New "Creating a Source Plugin" tutorial #37538
Changes from 39 commits
d8b0ee6
aa8ca7e
2adda9e
fa7f06d
d3d0466
96a4f0d
fd5d69c
918eff3
8a44d92
bb011de
5fc8c19
5625f3e
e2d34a3
2221703
9c083c8
0c636f8
736ab39
1530178
f49978a
14e3c0e
bf1d799
5e9a8e0
004c669
bf9bd68
5595813
1bedd5e
bf44d9b
0bc3b31
4e7675b
69e6282
d0e305c
ce08d0a
700409a
3e36776
a8e7d72
15bdce3
d1900c4
7ee49aa
b1933e3
bd6d99d
e2adaa5
f115392
85f1989
87fb180
a981034
84210ec
6d36693
32ab7c4
f665745
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some of the list items here end with a '.' and some don't. Is it if there are more than one sentence, then a period is required? Just wondering what approach the Gatsby docs use!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked it up in our style guide and we actually don't have rules for it 😅
But yes, I tend to do it like you described