-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-sitemap): remove splice for default filter #37916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-sitemap/src/__tests__/internals.js to verify this behavior
379a41e
to
341cd53
Compare
Description
Removing the defaults from the array appears to re-introduce the paths to the sitemap on incremental builds.
Documentation
Tests
Related Issues