Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-feed): Update README with clearer instructions #37930

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

geocine
Copy link
Contributor

@geocine geocine commented Apr 10, 2023

Description

link is not properly being replaced because the underlying option used by node-rss is site_url so I just created a mapping. custom_namespaces is another option used in node-rss to specify custom namespaces.

Documentation

link is already in documentation. added custom_namespaces to the documentation.

Tests

I clone a copy of this plugin using this process to test https://www.gatsbyjs.com/docs/creating-a-local-plugin/

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 10, 2023
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 11, 2023
@geocine geocine force-pushed the gatsby-plugin-feed branch from 6710d03 to 4364fd8 Compare April 12, 2023 15:19
@geocine geocine force-pushed the gatsby-plugin-feed branch from 4364fd8 to 91a45de Compare April 12, 2023 15:21
@geocine geocine changed the title fix(gatsby-plugin-feed): fix link not being replaced and expose custom_namespaces fix(gatsby-plugin-feed): update documentation and expose custom_namespaces Apr 12, 2023
@LekoArts LekoArts changed the title fix(gatsby-plugin-feed): update documentation and expose custom_namespaces chore(gatsby-plugin-feed): Update README with clearer instructions Apr 13, 2023
@LekoArts
Copy link
Contributor

I removed your addition to the plugin options because it's already covered by this unknown here:

I updated the README though, let me know if this is clearer to you.

@geocine
Copy link
Contributor Author

geocine commented Apr 13, 2023

I removed your addition to the plugin options because it's already covered by this unknown here:

I updated the README though, let me know if this is clearer to you.

Thank you, that make its clearer. I added custom_namespaces because I didn't want to see warnings.

@LekoArts
Copy link
Contributor

I've tried it locally with an example site of mine, when I use e.g. language inside feeds I don't get a warning.

@LekoArts LekoArts merged commit 4a1b2ce into gatsbyjs:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants