-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): move typing for enableStatefulSourceNodes
into Actions
#37933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 12, 2023
LekoArts
added
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Apr 12, 2023
LekoArts
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @pieh noted this in #37920 (comment) 👍
LekoArts
changed the title
fix: move typing for enableStatefulSourceNodes into Actions
fix(gatsby): move typing for Apr 12, 2023
enableStatefulSourceNodes
into Actions
This was referenced Jun 9, 2023
This was referenced May 13, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While merging master into #30855, I found out that the type definition of enableStatefulSourceNodes is at the wrong position.
My typescript is now happy with the change :)