Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Shadowing with resourceQuery #37938

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Apr 13, 2023

Description

Mimics the logic we already have in

const originalPageComponent = page.component
const splitPath = splitComponentPath(page.component)
(and below) inside the Shadowing resolver.

This way the correct component path containing the resourceQuery is returned.

Documentation

Not needed, this should already have worked.

Tests

Added an test to the themes E2E suite

Related Issues

Fixes #37925

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 13, 2023
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 13, 2023
@LekoArts LekoArts marked this pull request as ready for review April 13, 2023 12:37
@pieh pieh merged commit dc998d5 into master Apr 13, 2023
@pieh pieh deleted the shadowing-resource-query branch April 13, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GatsbyThemeComponentShadowingResolverPlugin fails to match shadowed components if the theme adds query params
2 participants