fix(gatsby): don't serve codeframes for files outside of compilation (#38059) #38063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
reviewed
May 5, 2023
Comment on lines
+4
to
+10
| it(`__file-code-frame`, () => { | ||
| cy.request( | ||
| `__file-code-frame?filePath=${cwd}/SHOULD_NOT_SERVE&lineNumber=0` | ||
| ).should(response => { | ||
| expect(response.body.codeFrame).not.to.match(/CYPRESS-MARKER/) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
v4 doesn't have the other endpoint (__original-stack-frame with skipSourceMap param) that would serve content outside of.
We probably should streamline this in v5 to have single handler instead of 2 the basically do same thing just used in different places, but that's outside of scope of this
pieh
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #38059 to the 4.25 release branch
(cherry picked from commit ed5855e)