New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): don't force leading slash for external paths in routes manifest (#38639) #38646

Merged

gatsbybot merged 1 commit into release/5.12 from backport-5.12-38639

Oct 19, 2023

Collaborator

gatsbybot commented Oct 19, 2023

Backporting #38639 to the 5.12 release branch

(cherry picked from commit 5dbcf9e)


          fix(gatsby): don't force leading slash for external paths in routes m…

c13a51d

…anifest (#38639)

* don't force leading slash for external redirects

* add test

* perf: regexp -> double String.startWith checks

---------

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit 5dbcf9e)

gatsbybot added the type: cherry label

Oct 19, 2023

gatsbot bot added the status: triage needed label

Oct 19, 2023

pieh added bot: merge on green and removed status: triage needed labels

Oct 19, 2023

pieh approved these changes

Oct 19, 2023

View reviewed changes

gatsbybot merged commit 8302bc8 into release/5.12

Oct 19, 2023

1 check failed

gatsbybot deleted the backport-5.12-38639 branch

October 19, 2023 15:34

techfg mentioned this pull request

Nov 6, 2023

feat(gatsby,gatsby-adapter-netlify): support pathPrefix and trailingSlash options #38666

Merged

This was referenced Nov 10, 2023

[Snyk] Upgrade gatsby-plugin-image from 3.0.0 to 3.12.2 X-oss-byte/gatsby-1#212

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-feed, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-remark-images, gatsby-transformer-remark, gatsby-transformer-sharp X-oss-byte/gatsby-1#213

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.8 X-oss-byte/gatsby-1#214

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.8 X-oss-byte/gatsby-1#215

Open

[Snyk] Upgrade gatsby-plugin-image from 3.0.0 to 3.12.2 X-oss-byte/gatsby-1#218

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-transformer-sharp X-oss-byte/gatsby-1#219

Open

[Snyk] Upgrade gatsby-plugin-image from 3.0.0 to 3.12.2 X-oss-byte/gatsby-1#217

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-source-wordpress, gatsby-transformer-sharp X-oss-byte/gatsby-1#216

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.8 X-oss-byte/gatsby-1#220

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.8 X-oss-byte/gatsby-1#221

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.8 X-oss-byte/gatsby-1#222

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.8 X-oss-byte/gatsby-1#223

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.9 X-oss-byte/gatsby-1#225

Open

[Snyk] Upgrade gatsby-plugin-image from 3.0.0 to 3.12.3 X-oss-byte/gatsby-1#226

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-source-filesystem, gatsby-transformer-sharp X-oss-byte/gatsby-1#227

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-source-wordpress, gatsby-transformer-sharp X-oss-byte/gatsby-1#228

Open

[Snyk] Upgrade gatsby-plugin-image from 3.0.0 to 3.12.3 X-oss-byte/gatsby-1#229

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.9 X-oss-byte/gatsby-1#230

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.9 X-oss-byte/gatsby-1#231

Open

[Snyk] Upgrade gatsby-plugin-image from 3.0.0 to 3.12.3 X-oss-byte/gatsby-1#232

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-feed, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-remark-images, gatsby-source-filesystem, gatsby-transformer-remark, gatsby-transformer-sharp X-oss-byte/gatsby-1#233

Open

This was referenced Dec 22, 2023

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#339

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#340

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.11 X-oss-byte/gatsby-1#341

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#342

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#343

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.11 X-oss-byte/gatsby-1#344

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#345

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#346

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.11 X-oss-byte/gatsby-1#347

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.11 X-oss-byte/gatsby-1#348

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.11 X-oss-byte/gatsby-1#349

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#350

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#351

Open

[Snyk] Upgrade: gatsby, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-source-wordpress, gatsby-transformer-sharp X-oss-byte/gatsby-1#352

Open

This was referenced Dec 29, 2023

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#353

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#354

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#355

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#356

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#357

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#359

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#360

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#361

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#362

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#363

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#364

Open

This was referenced Jan 6, 2024

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#365

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#366

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#367

Open

[Snyk] Upgrade gatsby from 5.0.0 to 5.12.12 X-oss-byte/gatsby-1#369

Open

[Snyk] Upgrade gatsby from 5.12.4 to 5.12.12 X-oss-byte/gatsby-1#370

Open

Labels

bot: merge on green type: cherry

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(gatsby): don't force leading slash for external paths in routes manifest (#38639) #38646

fix(gatsby): don't force leading slash for external paths in routes manifest (#38639) #38646

gatsbybot commented Oct 19, 2023

fix(gatsby): don't force leading slash for external paths in routes manifest (#38639) #38646

fix(gatsby): don't force leading slash for external paths in routes manifest (#38639) #38646

Conversation

gatsbybot commented Oct 19, 2023