Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when implementing apis twice #3889

Merged
merged 17 commits into from
Feb 27, 2018
Merged

Warn when implementing apis twice #3889

merged 17 commits into from
Feb 27, 2018

Commits on Feb 26, 2018

  1. Warn when replaceRenderer is implemented multiple times

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    acfe558 View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    66af1b9 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    959d7f4 View commit details
    Browse the repository at this point in the history

  4. Back out 'named arguments' change from apiRunner

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    5dae156 View commit details
    Browse the repository at this point in the history

  5. Re-add required import

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    c577de6 View commit details
    Browse the repository at this point in the history

  6. Add first draft of docs page

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    881f066 View commit details
    Browse the repository at this point in the history

  7. Simplify language based on results from Hemingway App 

    See http://www.hemingwayapp.com/
    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    e9de6c4 View commit details
    Browse the repository at this point in the history

  8. Implement docs feedback

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    6298c41 View commit details
    Browse the repository at this point in the history

  9. Capitalisation

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    44c30a4 View commit details
    Browse the repository at this point in the history

  10. Copy tweaks

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    3913207 View commit details
    Browse the repository at this point in the history

  11. More concise 'add internal plugins'

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    00f39e7 View commit details
    Browse the repository at this point in the history

  12. Use work from previous PR's to improve this 

    - remove duplicate error messages
- improve message format
- only run the last replaceRenderer plugin
    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    55b7d3f View commit details
    Browse the repository at this point in the history

  13. Remove unused import

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    360677b View commit details
    Browse the repository at this point in the history

  14. Use the reporter for nicer error formatting

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    57375ee View commit details
    Browse the repository at this point in the history

  15. Exit on error during build

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    68cfa35 View commit details
    Browse the repository at this point in the history

  16. Split code out into smaller functions and add tests

    @m-allanson
    m-allanson committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    a4807ee View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Update comments

    @m-allanson
    m-allanson committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    db3e56d View commit details
    Browse the repository at this point in the history