chore: disable telemetry #39137
chore: disable telemetry #39137
Conversation
gatsbot
bot
added
the
status: triage needed
pieh
force-pushed
the
chore/remove-telemetry
branch
2 times, most recently
from
5411e21 to
3d42489
Compare
pieh
force-pushed
the
chore/remove-telemetry
branch
2 times, most recently
from
24ee1ab to
e24ad92
Compare
pieh
force-pushed
the
chore/remove-telemetry
branch
from
e24ad92 to
b855a38
Compare
pieh
removed
the
status: triage needed
| return this.config.all | ||
| return this.config.all() |
There was a problem hiding this comment.
this was "wrong" before and after some changes typescript started to complain - https://github.com/gatsbyjs/gatsby/pull/39137/files/a3b9f5628f95c35e1b8f54cde9258708fc125ac7#diff-cca3d37894655cf103c925eb2e8d20ccdab86c9fc6e1093f60777acd06be4550L20 the config could be one of two types before, but in here I did remove ConfigStore (this would be stuff that write/read some settings to ~/.config/<some-tool>) and kept just MemoryConfig which interface wasn't actually compatible apparently
| } | ||
|
|
||
| flush() | ||
| // no-op |
There was a problem hiding this comment.
this file can be deleted, I think?
There was a problem hiding this comment.
Very possible, yes.
The tricky bit here is that gatsby-telemetry doesn't have well defined public API surface and some other packages use non-main modules (and there is no export map) and I just am not sure that this module was never used by other packages and decided to keep module there. This module was not used by latest versions of packages (that part I did check) but I don't know about all the previous versions within current major.
The main goal of those changes was ensuring this new version will just not POST to now disabled collection endpoint - there is still quite a bit of code that is left in this package so I think this is reasonable to keep that module in
Description
Telemetry endpoint was shut down and telemetry is no longer functional so this looks to produce
gatsby-telemetrypackage with no-op functions, so that already release gatsby (and gatsby packages that use telemetry) could possibly get telemetry package upgrade and avoid POSTing to no longer working telemetry endpoint as that's just wasteful. Note thatgatsby-telemetrydependency is not pinned so it's technically possible to get that new version but also likely won't happen that often as the version would be pinned by lock file. Regardless of that it seems worth to make it possible to get updated telemetry package that skips trying to hit collection endpoint.This PR also removes "vendored" telemetry usage from
create-gatsbyand usage ofgatsby-telemetryfrom other packages.Removal of usage from packages was intentionally done in commit after making
gatsby-telemetryno-op to show that both pass testsDocumentation
Tests
Related Issues
https://linear.app/netlify/issue/FRB-1396/deprecate-telemetry-functionality-in-gatsbyjs