Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 💥 Sitemap excludes should ignore trailing slashes #4655

Conversation

rmehner
Copy link
Contributor

@rmehner rmehner commented Mar 22, 2018

I ran into #4621 on my project and wanted to fix this. I first thought that adding the slashes to the default excludes would be enough, but thinking a bit more about this, I actually think it's nicer if it just ignores the trailing slash, as this would also bite users for their custom exclude paths.

Alternatively one could install the gatsby-plugin-remove-trailing-slashes plugin, but I wanted this to work out of the box without dependencies to another module.

Let me know what you think about this, happy to adapt where it's needed.

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit c3fea2c

https://deploy-preview-4655--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit c3fea2c

https://deploy-preview-4655--gatsbygram.netlify.com

@KyleAMathews KyleAMathews merged commit 9aa9a21 into gatsbyjs:master Mar 22, 2018
@KyleAMathews
Copy link
Contributor

Makes sense! Thanks for the PR!

@rmehner rmehner deleted the bugfixes/sitemap-excludes-ignore-trailing-slash branch March 22, 2018 21:12
@jlengstorf
Copy link
Contributor

Hiya @rmehner! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants