🐞 💥 Sitemap excludes should ignore trailing slashes #4655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #4621 on my project and wanted to fix this. I first thought that adding the slashes to the default excludes would be enough, but thinking a bit more about this, I actually think it's nicer if it just ignores the trailing slash, as this would also bite users for their custom exclude paths.
Alternatively one could install the gatsby-plugin-remove-trailing-slashes plugin, but I wanted this to work out of the box without dependencies to another module.
Let me know what you think about this, happy to adapt where it's needed.