-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[www] Move Plugins page from /packages to /plugins #4705
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cef7859
move plugins page from /packages to /plugins
tsriram 4407944
revert package slug to /packages
tsriram 9bf991d
/packages instead of /plugins as path for packages
tsriram 44967da
fix formatting
tsriram 1787a8f
Update index.js
KyleAMathews 93c7b08
Update index.js
KyleAMathews f3df75b
Merge remote-tracking branch 'origin/master' into tsriram-plugins-page
KyleAMathews bd45464
Fix sidebar
KyleAMathews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,9 +31,9 @@ class DefaultLayout extends React.Component { | |
const isTutorial = | ||
this.props.location.pathname.slice(0, 10) === `/tutorial/` | ||
const isFeature = this.props.location.pathname.slice(0, 9) === `/features` | ||
const isPackage = this.props.location.pathname.slice(0, 9) === `/packages` | ||
const isPackage = this.props.location.pathname.slice(0, 8) === `/plugins` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also check if the pathname is |
||
const isPackageReadme = | ||
this.props.location.pathname.slice(0, 16) === `/packages/gatsby` | ||
this.props.location.pathname.slice(0, 15) === `/plugins/gatsby` | ||
|
||
const hasSidebar = | ||
isDoc || isTutorial || isFeature || isPackage || isPackageReadme | ||
|
@@ -42,7 +42,7 @@ class DefaultLayout extends React.Component { | |
const packageSidebarWidth = rhythm(17) | ||
|
||
const leftPadding = rhythmSize => { | ||
if (this.props.location.pathname.slice(0, 9) === `/packages`) { | ||
if (this.props.location.pathname.slice(0, 8) === `/plugins`) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check for |
||
return packageSidebarWidth | ||
} else if (hasSidebar) { | ||
return rhythm(rhythmSize) | ||
|
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this