Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Update Babel to 7.0.0-beta.49 #5620

Merged
merged 2 commits into from
May 31, 2018
Merged

Conversation

dennari
Copy link
Contributor

@dennari dennari commented May 31, 2018

Update to the newest Babel beta in preparation for updating gatsby-plugin-typescript to use @babel/preset-typescript.

@dennari
Copy link
Contributor Author

dennari commented May 31, 2018

The failing test is the one that is fixed in #5602

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks :)

@KyleAMathews
Copy link
Contributor

I'm working on merging this in

@KyleAMathews KyleAMathews merged commit 1d27060 into gatsbyjs:v2 May 31, 2018
@dennari dennari deleted the v2-babel-49 branch May 31, 2018 17:45
@KyleAMathews
Copy link
Contributor

I had to revert this — it seems to have broke things for us somehow — both gatsbyjs.org + gatsby-starter-blog stopped working. Tried digging into Babel changes before giving up as have other v2 stuff want to make progress on.

@dennari
Copy link
Contributor Author

dennari commented Jun 1, 2018

Damn. It would seem worthwhile to investigate what happened and have a test that would catch it. I can try to do that.

@KyleAMathews
Copy link
Contributor

It broke hot reloading & anytime I was using bind in my components for a class method and it said it couldn't find the method.

@dennari
Copy link
Contributor Author

dennari commented Jun 3, 2018

Finally got around to testing this. It's quite painful to get the website to resolve its dependencies to the monorepo packages. Managed it in the end by using file:../packages/gatbsy type of paths in the www package.json. Anyway, once I managed to do that, I couldn't reproduce any problems.

At one point I had forgotten to run yarn bootstrap at the repo root after upgrading to Babel v49 which lead to a broken site with bind related errors in the console. In this case the packages had been traspiled with v47 while the runtime etc. was from v49.

@KyleAMathews
Copy link
Contributor

Oh yeah — not running yarn bootstrap before upgrading could very well be the problem. @m-allanson or @pieh — want to try merging this PR again and making sure to run bootstrap first then publish?

@m-allanson m-allanson mentioned this pull request Jun 13, 2018
@jlengstorf
Copy link
Contributor

Hiya @dennari! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants