-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Update Babel to 7.0.0-beta.49 #5620
Conversation
The failing test is the one that is fixed in #5602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks :)
I'm working on merging this in |
I had to revert this — it seems to have broke things for us somehow — both gatsbyjs.org + gatsby-starter-blog stopped working. Tried digging into Babel changes before giving up as have other v2 stuff want to make progress on. |
Damn. It would seem worthwhile to investigate what happened and have a test that would catch it. I can try to do that. |
It broke hot reloading & anytime I was using bind in my components for a class method and it said it couldn't find the method. |
Finally got around to testing this. It's quite painful to get the website to resolve its dependencies to the monorepo packages. Managed it in the end by using At one point I had forgotten to run |
Oh yeah — not running yarn bootstrap before upgrading could very well be the problem. @m-allanson or @pieh — want to try merging this PR again and making sure to run bootstrap first then publish? |
Hiya @dennari! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Update to the newest Babel beta in preparation for updating
gatsby-plugin-typescript
to use@babel/preset-typescript
.