Support typescript when parsing GraphQL queries #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also extract ast parsing into a utility function
dennari
commented
Jul 7, 2018
| @@ -24,25 +24,7 @@ module.exports = (modulePath, resolver = require.resolve) => { | |||
| } | |||
| const code = fs.readFileSync(absPath, `utf8`) // get file contents | |||
|
|
|||
| const babylonOpts = { | |||
There was a problem hiding this comment.
This is now using the larger set of plugins. Hopefully that's not a problem?
|
I'm going to be away for two weeks, so please feel free to modify this PR as needed and merge it in. |
|
Deploy preview for using-drupal ready! Built with commit feae623 |
|
Deploy preview for gatsbygram ready! Built with commit feae623 |
|
its working for me |
KyleAMathews
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Looks good to me!
/cc @jquense @m-allanson @pieh look good?
m-allanson
approved these changes
Jul 10, 2018
There was a problem hiding this comment.
@dennari Thanks for your patience with seeing this through. This LGTM 👍
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also extract ast parsing into a utility function