Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plugin stub descriptions with actual descriptions. #8677

Merged

Conversation

siakaramalegos
Copy link
Contributor

Connects #5073

Replaces all stubbed plugin descriptions with real ones so that the search page will show real descriptions:

image

I'm having trouble getting the local www folder/project running in development, so this PR still needs verification.

@@ -1,6 +1,6 @@
# gatsby-plugin-twitter

Loads the Twitter JavaScript for embedding tweets. Let's you add tweets to
Loads the Twitter JavaScript for embedding tweets. Lets you add tweets to
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed grammar here, fyi.

@siakaramalegos
Copy link
Contributor Author

See #5073 (comment) - In this PR I'm assuming Algolia's React InstantSearch is using the core /packages/ folder as it's data source, but I cannot verify. Someone on the team that has access to the React InstantSearch set up will need to verify. The dev version does not point directly to the local /packages/ folder.

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks!

@DSchau DSchau merged commit 3c61d47 into gatsbyjs:master Oct 1, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 1, 2018

Holy buckets, @siakaramalegos — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants