Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

[WIP] Add rule for closing new pull requests to starter repos #64

Merged
merged 3 commits into from
Dec 20, 2018

Conversation

sidharthachatterjee
Copy link
Contributor

This should suffice for closing new pull requests to starters (with a comment)

Added a test for the new rule and updated settings to make it run on pull_request.opened for

  • gatsbyjs/gatsby-starter-default
  • gatsbyjs/gatsby-starter-hello-world
  • gatsbyjs/gatsby-starter-blog

We need to update the comment before merging this in, hence the WIP

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks for adding this!

I think @pieh will help validate when he gets a chance, but this is great 💪

DSchau and others added 2 commits December 20, 2018 00:12
Co-Authored-By: sidharthachatterjee <me@sidharthachatterjee.com>
@pieh
Copy link
Contributor

pieh commented Dec 20, 2018

This was validated on my repo - pieh/gatsby-starter-default-nprogress#3

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pieh pieh merged commit 2dbfe8f into master Dec 20, 2018
@m-allanson m-allanson deleted the feature/pull-request-on-starter branch December 27, 2018 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants