Emulate multipart upload with single-part uploads #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This implements the multipart API at a ruinous cost -- writing, reading, and re-writing every part. I am not sure if it is worth merging but it demonstrates all the required functionality that we need to migrate into jclouds. |
gaul
force-pushed
the
emulated-multipart
branch
from
e7c81e4 to
21b6d8f
Compare
|
Andrew Gaul » s3proxy #44 SUCCESS |
gaul
force-pushed
the
emulated-multipart
branch
2 times, most recently
from
b3fbfb6 to
c82825a
Compare
gaul
force-pushed
the
emulated-multipart
branch
from
c82825a to
44841bb
Compare
gaul
force-pushed
the
emulated-multipart
branch
from
44841bb to
3363687
Compare
gaul
force-pushed
the
emulated-multipart
branch
2 times, most recently
from
5d2ab56 to
e38fb02
Compare
This approach requires three times as many operations as the optimal approach. Implementing this correctly requires exposing the underlying multipart operations in jclouds. Most s3-tests pass but test_list_multipart_upload still fails: References #2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach requires three times as many operations as the optimal
approach. Implementing this correctly requires exposing the
underlying multipart operations in jclouds. Most s3-tests pass but
two still fail:
test_multipart_upload_size_too_small
test_list_multipart_upload
References #2.