Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check of host certificate #42

Closed
cym13 opened this issue Apr 16, 2017 · 2 comments · Fixed by #44
Closed

No check of host certificate #42

cym13 opened this issue Apr 16, 2017 · 2 comments · Fixed by #44

Comments

@cym13
Copy link

cym13 commented Apr 16, 2017

All calls with request.get have disabled certificate verification. This puts the user in danger of a man in the middle.

While the information in those pages isn't private this opens the door to modification of the results. Those results are then printed on screen.

One possible attack scenario is to inject terminal control characters. Some terminal emulators allow things like writing a log to a file through control characters. This could therefore lead to remote code execution.

I see no good reason to disable those security features and recommend turning them on.

@gautamkrishnar
Copy link
Owner

Thanks... 👍 Yes SSL must be enabled...

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Apr 17, 2017

Instructions to fix the issue

  • Comment in this issue if you are interested 👍
  • Find all lines containing:
requests.get(soqurl + query, verify=False)
  • Change it to:
requests.get(soqurl + query)
  • Submit a new Pull request ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants