Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify certificates during request.get() #44

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Verify certificates during request.get() #44

merged 1 commit into from
Apr 17, 2017

Conversation

liamhawkins
Copy link
Contributor

pull request to fix #42

gautamkrishnar
gautamkrishnar reviewed Apr 17, 2017
View reviewed changes
Copy link
Owner

@gautamkrishnar gautamkrishnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gautamkrishnar gautamkrishnar merged commit 9ab7a62 into gautamkrishnar:master Apr 17, 2017
@gautamkrishnar
Copy link
Owner

@liamhawkins Kudos on your first contribution ⭐️

@liamhawkins liamhawkins deleted the certcheck branch April 18, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautamkrishnar gautamkrishnar gautamkrishnar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No check of host certificate
2 participants
@liamhawkins @gautamkrishnar