Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Value.IsXxx #257

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Add Value.IsXxx #257

merged 1 commit into from
Feb 1, 2023

Conversation

nhAnik
Copy link
Contributor

@nhAnik nhAnik commented Jan 31, 2023

Closes #253

@coveralls
Copy link
Collaborator

coveralls commented Jan 31, 2023 •
edited
Loading

Coverage Status

Coverage: 94.902% (+0.1%) from 94.806% when pulling fb9a627 on nhAnik:253-value-isxxx into f27bf25 on gavv:master.

@gavv
Copy link
Owner

gavv commented Jan 31, 2023 •
edited
Loading

Thanks for pr! Will review in upcoming days. Please take a look why coverage decreased.

@gavv gavv added the ready for review Pull request can be reviewed label Jan 31, 2023
@gavv
Copy link
Owner

gavv commented Feb 1, 2023

Thanks, the changes look good!

Sorry, seems I forgot to mention in the issue: in httpexpect each Is method should have counterpart Not method. For example, for IsObject, we also need NotObject. Could you please add them too?

@gavv gavv added needs revision Pull request should be revised by its author and removed ready for review Pull request can be reviewed labels Feb 1, 2023
@nhAnik
Copy link
Contributor Author

nhAnik commented Feb 1, 2023

Sure, I will add them.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

@github-actions github-actions bot added the needs rebase Pull request has conflicts and should be rebased label Feb 1, 2023
@gavv gavv removed needs revision Pull request should be revised by its author needs rebase Pull request has conflicts and should be rebased labels Feb 1, 2023
@gavv
Copy link
Owner

gavv commented Feb 1, 2023

LGTM!

@gavv gavv merged commit 8354628 into gavv:master Feb 1, 2023
@gavv
Copy link
Owner

gavv commented Feb 1, 2023

BTW, welcome to our discord chat!

@nhAnik
Copy link
Contributor Author

nhAnik commented Feb 2, 2023

Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Value.IsXxx
3 participants
@nhAnik @coveralls @gavv