Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in Garden: ign-rendering and dependents #545

Closed
34 of 35 tasks
scpeters opened this issue Nov 4, 2021 · 15 comments
Closed
34 of 35 tasks

Bump in Garden: ign-rendering and dependents #545

scpeters opened this issue Nov 4, 2021 · 15 comments

Comments

@scpeters
Copy link
Contributor

scpeters commented Nov 4, 2021

This is similar to #331

Libraries being bumped:

@scpeters
Copy link
Contributor Author

I just ran the bump_dependency.bash script, and I think there's room for improvement. I'll make some suggestions as I look over the process

@j-rivero
Copy link
Contributor

* ignition-rendering7: needed to support wide-angle cameras, which require new virtual functions in Scene.hh

I really like this descriptions on why we need to bump majors. It could help a lot for many different things in the future. Would be great if we add them to every library bump.

@chapulina
Copy link
Contributor

I just ran the bump_dependency.bash script

Ouch, so the rest of the PRs weren't open? 😢

@scpeters
Copy link
Contributor Author

scpeters commented Nov 15, 2021

I just ran the bump_dependency.bash script

Ouch, so the rest of the PRs weren't open? 😢

I didn't open the homebrew pull requests because they were modifying the fortress formula instead of creating a new one for garden

@chapulina
Copy link
Contributor

chapulina commented Nov 15, 2021

they were modifying the fortress formula instead of creating a new one for garden

ouch, I see 😕 Let me know if you need help navigating the messy script. For Fortress the script correctly created all these new formulae:

https://github.com/osrf/homebrew-simulation/pulls?q=is%3Apr+bumps+in+fortress+is%3Aclosed+author%3Achapulina+

@scpeters
Copy link
Contributor Author

@adlarkin I believe osrf/homebrew-simulation#1685 is the first homebrew formula that we should merge

@scpeters
Copy link
Contributor Author

@adlarkin I believe osrf/homebrew-simulation#1685 is the first homebrew formula that we should merge

also #558 will be needed so we can start building nightlies of ign-rendering7

@scpeters
Copy link
Contributor Author

@adlarkin could you update gzdev to use nightlies following the pattern of gazebo-tooling/gzdev#31 ?

@scpeters
Copy link
Contributor Author

they were modifying the fortress formula instead of creating a new one for garden

ouch, I see confused Let me know if you need help navigating the messy script. For Fortress the script correctly created all these new formulae:

https://github.com/osrf/homebrew-simulation/pulls?q=is%3Apr+bumps+in+fortress+is%3Aclosed+author%3Achapulina+

I've suggested some improvements to the bump_dependency.bash script for the homebrew formula generation in #557

@scpeters
Copy link
Contributor Author

@adlarkin could you update gzdev to use nightlies following the pattern of ignition-tooling/gzdev#31 ?

gazebo-tooling/gzdev#40

@scpeters
Copy link
Contributor Author

@scpeters
Copy link
Contributor Author

@chapulina
Copy link
Contributor

I think this is not needed for ign-rendering, but only for its dependents

It wasn't immediately necessary for this bump, but it was necessary for subsequent bumps in #574. I think it's easier to maintain gzdev if we just enable nightlies for all main branches, or at least all the ones we're bumping, instead of analyzing case-by-case and having to revisit it for every bump.

Doing it in gazebo-tooling/gzdev#49

@scpeters
Copy link
Contributor Author

I think this is not needed for ign-rendering, but only for its dependents

It wasn't immediately necessary for this bump, but it was necessary for subsequent bumps in #574. I think it's easier to maintain gzdev if we just enable nightlies for all main branches, or at least all the ones we're bumping, instead of analyzing case-by-case and having to revisit it for every bump.

Doing it in ignition-tooling/gzdev#49

sounds reasonable

@chapulina
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants